Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation context issue #749

Merged
merged 6 commits into from
May 3, 2024
Merged

Conversation

Tofandel
Copy link
Contributor

Follow up of #720 in which I also fixed the creation context path being invalid when going into nested collections

Also added the test of #720 which was not added to main to avoid a future regression

@Tofandel Tofandel changed the title Fix creation context issue and exception thrown Fix creation context issue Apr 15, 2024
@Tofandel Tofandel force-pushed the fix/exception branch 2 times, most recently from dca1dba to 7871708 Compare April 15, 2024 13:51
Add failing test about nested collection lazy
tests/CreationTest.php Outdated Show resolved Hide resolved
@rubenvanassche
Copy link
Member

Thanks!

@rubenvanassche rubenvanassche merged commit ecea4cc into spatie:main May 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants