Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined array key error in SnapshotRepository::getAll() #120

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Fix undefined array key error in SnapshotRepository::getAll() #120

merged 2 commits into from
Jul 29, 2022

Conversation

eli-s-r
Copy link
Contributor

@eli-s-r eli-s-r commented Jun 17, 2022

Simple fix for #117 — don't try to access extension of file's pathinfo unless it exists

freekmurze
freekmurze requested changes Jun 17, 2022
View reviewed changes
src/SnapshotRepository.php Outdated Show resolved Hide resolved
@eli-s-r eli-s-r requested a review from freekmurze June 17, 2022 23:38
@oulfr
Copy link

oulfr commented Jul 27, 2022

can you merge this request i have the same issue

@freekmurze freekmurze merged commit 1ea4c17 into spatie:main Jul 29, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze Awaiting requested review from freekmurze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eli-s-r @oulfr @freekmurze