Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-empty subdirectories are deleted #26

Closed
bluec opened this issue Jan 18, 2019 · 2 comments
Closed

Non-empty subdirectories are deleted #26

bluec opened this issue Jan 18, 2019 · 2 comments
Labels
bug good first issue

Comments

@bluec
Copy link
Contributor

bluec commented Jan 18, 2019

Seems that non-empty subdirectories are deleted if they contain hidden dotfiles like .gitignore etc
@bluec
Copy link
Contributor Author

bluec commented Jan 18, 2019

Just looking into this. Will raise a related issue too. I would be interested in writing a test and PR for this if you give me time. I am keen to learn!

This was referenced Jan 18, 2019
Closed
Merged
freekmurze pushed a commit that referenced this issue Jan 18, 2019
@bluec @freekmurze
Don't delete non-empty subdirectories that contain hidden files (#26)…
40c3b4a 
… and delete hidden files (#27) (#28)
@freekmurze
Copy link
Member

PR seems good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freekmurze @bluec