Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Add event_class_map for event class aliases #178

Merged
merged 6 commits into from
Jul 18, 2019
Merged

Add event_class_map for event class aliases #178

merged 6 commits into from
Jul 18, 2019

Conversation

riasvdv
Copy link
Member

@riasvdv riasvdv commented Jul 17, 2019

Fixes #177

@riasvdv riasvdv marked this pull request as ready for review July 17, 2019 07:52
@riasvdv riasvdv requested a review from freekmurze July 17, 2019 07:52
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👍

Could you also document this feature?

src/Models/StoredEvent.php Outdated Show resolved Hide resolved
src/Models/StoredEvent.php Outdated Show resolved Hide resolved
src/Models/StoredEvent.php Outdated Show resolved Hide resolved
src/Models/StoredEvent.php Outdated Show resolved Hide resolved
@riasvdv riasvdv requested a review from freekmurze July 18, 2019 07:42
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little consideration left...

src/Models/StoredEvent.php Outdated Show resolved Hide resolved
@riasvdv riasvdv requested a review from freekmurze July 18, 2019 07:51
@freekmurze freekmurze merged commit af6fa8b into master Jul 18, 2019
@freekmurze
Copy link
Member

Perfect, thanks!

@freekmurze freekmurze deleted the event-map branch July 18, 2019 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow aliases for stored event classes instead of persisting FQCN to DB
2 participants