Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Ensure eloquent stored events are retrieved in order of ID. #189

Merged
merged 5 commits into from Sep 5, 2019
Merged

Ensure eloquent stored events are retrieved in order of ID. #189

merged 5 commits into from Sep 5, 2019

Conversation

adrianb93
Copy link
Contributor

@adrianb93 adrianb93 commented Sep 4, 2019

I have an app with a postgres database. Records don't return in order of insert for me so my apps tests were failing. This PR does two things:

  • So that the aggregate has events applied in the correct order, the query will be ordered by id.
  • Supports the pgsql driver for this test suite.

@adrianb93 adrianb93 marked this pull request as ready for review September 4, 2019 13:54
@adrianb93
Copy link
Contributor Author

I am not familiar with Travis. Is there a way to run the test suite twice on different configurations?

@riasvdv
Copy link
Member

riasvdv commented Sep 5, 2019

Testing both mysql and pgsql will be a bit more involved

  • We'll need to update the docker-compose file
  • Add the database driver as an env variable in Travis (I've just updated the Travis config to make this easier)

I suggest a different PR for this, then we can go ahead and merge this one.

@riasvdv riasvdv merged commit 320349a into spatie:master Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants