[LaraPackagePort] Analyse for Laravel 5.5 #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2017 13:20
|
@freekmurze This is mergeable (all Tests are OK) |
freekmurze
reviewed
Aug 3, 2017
composer.json
Outdated
| @@ -22,12 +22,12 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^5.6|^7.0", | |||
| "illuminate/contracts": "~5.1.0|~5.2.0|~5.3.0|~5.4.0|~5.5.x-dev", | |||
| "illuminate/support": "~5.1.0|~5.2.0|~5.3.0|~5.4.0|~5.5.x-dev", | |||
| "illuminate/contracts": "~5.1.0|~5.2.0|~5.3.0|~5.4.0|~5.5.x-dev|~5.5.x-dev", | |||
There was a problem hiding this comment.
Mmm, why are the new deps added twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-Requests help you to prepare your Package for Laravel 5.5. I've tested it automated and this was the PHPUnit Result:
PHPUnit 6.3-dev by Sebastian Bergmann and contributors.
Runtime: PHP 7.1.7 with Xdebug 2.5.5
Configuration: /Users/lukaskammerling/Code/OSS/spatieLaravelphp5.5/storage/spatie.laravel-fractal/phpunit.xml.dist
........................... 27 / 27 (100%)
Time: 4.72 seconds, Memory: 12.00MB
OK (27 tests, 34 assertions)
Generating code coverage report in Clover XML format ... done
Generating code coverage report in HTML format ... done
Nice looks really good! There are no Errors so it might work in Laravel 5.5 without any adjustments