Merge pull request #107 from moisish/throttling-notifications-per-cha…

…nnel Failed Notification Cache Per Channel
spatie · Jul 29, 2022 · 0d2ebcc · 0d2ebcc
2 parents a114243 + 9767b8e
commit 0d2ebcc
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Checks/Checks/ScheduleCheck.php b/src/Checks/Checks/ScheduleCheck.php
@@ -8,7 +8,7 @@
 
 class ScheduleCheck extends Check
 {
-    protected string $cacheKey = 'health.checks.schedule.latestHeartbeatAt';
+    protected string $cacheKey = 'health:checks:schedule:latestHeartbeatAt';
 
     protected ?string $cacheStoreName = null;
 

diff --git a/src/Notifications/CheckFailedNotification.php b/src/Notifications/CheckFailedNotification.php
@@ -39,7 +39,7 @@ public function shouldSend(Notifiable $notifiable, string $channel): bool
             return true;
         }
 
-        $cacheKey = 'health.latestNotificationSentAt';
+        $cacheKey = 'health:latestNotificationSentAt:'.$channel;
 
         /** @var \Illuminate\Cache\CacheManager $cache */
         $cache = app('cache');

diff --git a/src/ResultStores/CacheHealthResultStore.php b/src/ResultStores/CacheHealthResultStore.php
@@ -11,7 +11,7 @@ class CacheHealthResultStore implements ResultStore
 {
     public function __construct(
         public string $store = 'file',
-        public string $cacheKey = 'healthStoreResults',
+        public string $cacheKey = 'health:storeResults',
     ) {
     }
 

diff --git a/tests/ResultStores/CacheHealthResultStoreTest.php b/tests/ResultStores/CacheHealthResultStoreTest.php
@@ -26,7 +26,7 @@
 it('can cache check results', function () {
     artisan(RunHealthChecksCommand::class)->assertSuccessful();
 
-    $json = cache()->store('file')->get('healthStoreResults');
+    $json = cache()->store('file')->get('health:storeResults');
 
     assertMatchesJsonSnapshot($json);
 });