wip

spatie · Jan 23, 2024 · 75c8a2e · 75c8a2e
2 parents e08c8f9 + 084523d
commit 75c8a2e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/src/Checks/Checks/BackupsCheck.php b/src/Checks/Checks/BackupsCheck.php
@@ -14,6 +14,7 @@ class BackupsCheck extends Check
     protected ?string $locatedAt = null;
 
     protected ?Carbon $youngestShouldHaveBeenMadeBefore = null;
+
     protected ?Carbon $oldestShouldHaveBeenMadeAfter = null;
 
     protected int $minimumSizeInMegabytes = 0;
@@ -93,31 +94,28 @@ public function run(): Result
         if ($this->youngestShouldHaveBeenMadeBefore) {
             if ($this->youngestBackupIsToolOld($eligableBackups)) {
                 return Result::make()
-                    ->failed("Youngest backup was too old");
+                    ->failed('Youngest backup was too old');
             }
         }
 
         if ($this->oldestShouldHaveBeenMadeAfter) {
             if ($this->oldestBackupIsTooYoung($eligableBackups)) {
                 return Result::make()
-                    ->failed("Oldest backup was too young");
+                    ->failed('Oldest backup was too young');
             }
         }
 
         return Result::make()->ok();
     }
 
-
     /**
-     * @param Collection<SymfonyFile> $backups
-     *
-     * @return bool
+     * @param  Collection<SymfonyFile>  $backups
      */
     protected function youngestBackupIsToolOld(Collection $backups): bool
     {
         /** @var SymfonyFile|null $youngestBackup */
         $youngestBackup = $backups
-            ->sortByDesc(fn(SymfonyFile $file) => $file->getMTime())
+            ->sortByDesc(fn (SymfonyFile $file) => $file->getMTime())
             ->first();
 
         $threshold = $this->youngestShouldHaveBeenMadeBefore->getTimestamp();
@@ -126,15 +124,13 @@ protected function youngestBackupIsToolOld(Collection $backups): bool
     }
 
     /**
-     * @param Collection<SymfonyFile> $backups
-     *
-     * @return bool
+     * @param  Collection<SymfonyFile>  $backups
      */
     protected function oldestBackupIsTooYoung(Collection $backups): bool
     {
         /** @var SymfonyFile|null $oldestBackup */
         $oldestBackup = $backups
-            ->sortBy(fn(SymfonyFile $file) => $file->getMTime())
+            ->sortBy(fn (SymfonyFile $file) => $file->getMTime())
             ->first();
 
         $threshold = $this->oldestShouldHaveBeenMadeAfter->getTimestamp();

diff --git a/tests/Checks/DatabaseCheckTest.php b/tests/Checks/DatabaseCheckTest.php
@@ -2,7 +2,6 @@
 
 use Spatie\Health\Checks\Checks\DatabaseCheck;
 use Spatie\Health\Enums\Status;
-use function Spatie\PestPluginTestTime\testTime;
 
 it('will determine that a working database connection is ok', function () {
     $result = DatabaseCheck::new()

diff --git a/tests/Pest.php b/tests/Pest.php
@@ -25,7 +25,7 @@ function getTemporaryDirectory(string $path = ''): string
     return __DIR__."/temp/{$path}";
 }
 
-function addTestFile(string $path, Carbon $date = null, int $sizeInMb = null): void
+function addTestFile(string $path, ?Carbon $date = null, ?int $sizeInMb = null): void
 {
     $date = $date ?? now();