Database Size Check Throw error when i used PostgreSQL Database

[Zubairsoft]

• Laravel v9.40
• Postgres v15.2

I am using this package to check my application health and everything is going well. However, when I checked the size of the database using the DataBaseSizeCheck class, it threw an error:

Spatie\Health\Support\DbConnectionInfo::getPostgresDatabaseSize(): Return value must be of type int, string returned

at vendor/spatie/laravel-health/src/Support/DbConnectionInfo.php:67
63▕ protected function getPostgresDatabaseSize(ConnectionInterface $connection): int
64▕ {
65▕ return $connection->selectOne('SELECT pg_size_pretty(pg_database_size(?)) AS size;', [
66▕ $connection->getDatabaseName(),
➜ 67▕ ])->size;
68▕ }
69▕ }
70▕

I think this issue is related to the return type hint of getPostgresDatabaseSize() method it actually returns a string but the return type hint is an integer.

Thank you.

[Zubairsoft]

@freekmurze @eduardocruz @dominikkukacka @tominon

[SUXUMI]

Yeap, I also faced the sameTypeError - Spatie\Health\Support\DbConnectionInfo::getPostgresDatabaseSize(): Return value must be of type int, string returned. Hope they will fix this small issue asap.

laravel-health/src/Support/DbConnectionInfo.php

Line 63 in d1b4e93

protected function getPostgresDatabaseSize(ConnectionInterface $connection): int

[freekmurze]

We need the size as an int (or float) as we use that in the the db size check to determine if your db is too large.

I'm not a postgres user myself (this functionality was contributed). I'd appreciate a PR that fixes this, not by changing the typehint, but by making sure the function actual returns an int.

[SUXUMI]

Hi, @freekmurze so I've done a tiny update and maybe someone could check it #170. Thanks

[freekmurze]

Done, I've released a new version containing that fix. Thanks!

[SUXUMI]

Thank you very much