nitpicks

spatie · Sep 19, 2017 · 9ec87b9 · 9ec87b9
1 parent 311634d
commit 9ec87b9
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 13 deletions.
diff --git a/src/Exceptions/UrlCannotBeDetermined.php b/src/Exceptions/UrlCannotBeDetermined.php
@@ -11,7 +11,7 @@ public static function mediaNotPubliclyAvailable(string $storagePath, string $pu
         return new static("Storagepath `{$storagePath}` is not part of public path `{$publicPath}`");
     }
 
-    public static function temporaryUrlOnlyWorksOnS3()
+    public static function filesystemDoesNotSupportTemporaryUrls()
     {
         return new static('Generating temporary URLs only works on the S3 filesystem driver');
     }

diff --git a/src/Media.php b/src/Media.php
@@ -68,15 +68,6 @@ public function getUrl(string $conversionName = ''): string
         return $urlGenerator->getUrl();
     }
 
-    /**
-     * Get a temporary url to a original media file.
-     *
-     * @param string             $conversionName
-     * @param \DateTimeInterface $expiration
-     * @param array              $options
-     *
-     * @return string
-     */
     public function getTemporaryUrl(DateTimeInterface $expiration, string $conversionName = '', array $options = []): string
     {
         $urlGenerator = UrlGeneratorFactory::createForMedia($this, $conversionName);

diff --git a/src/UrlGenerator/LocalUrlGenerator.php b/src/UrlGenerator/LocalUrlGenerator.php
@@ -35,7 +35,7 @@ public function getUrl(): string
      */
     public function getTemporaryUrl(DateTimeInterface $expiration, array $options = []): string
     {
-        throw UrlCannotBeDetermined::temporaryUrlOnlyWorksOnS3();
+        throw UrlCannotBeDetermined::filesystemDoesNotSupportTemporaryUrls();
     }
 
     /*

diff --git a/src/UrlGenerator/S3UrlGenerator.php b/src/UrlGenerator/S3UrlGenerator.php
@@ -32,7 +32,7 @@ public function getUrl(): string
      * Get the temporary url for the profile of a media item.
      *
      * @param \DateTimeInterface $expiration
-     * @param array              $options
+     * @param array $options
      *
      * @return string
      */

diff --git a/src/UrlGenerator/UrlGenerator.php b/src/UrlGenerator/UrlGenerator.php
@@ -20,7 +20,7 @@ public function getUrl(): string;
      * Get the temporary url for the profile of a media item.
      *
      * @param \DateTimeInterface $expiration
-     * @param array              $options
+     * @param array $options
      *
      * @return string
      */