When streaming media, replace with feof/fread instead of fpassthru #3501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ran into an issue where when returning a Media item directly in our controller, it was building our response as a stream but hitting memory allocation errors.
The reason for this is the functionality of fpassthru. It's designed to 'Output all remaining data on a file pointer' - https://www.php.net/manual/en/function.fpassthru.php
This update uses feof/fread to instead chunk the output and clear the buffers, preventing memory issues.
I've also added a setter to allow modification of the chunk size. Example usage:
While I was in the project I've also added a helper method to get a stream for a conversion, this was something that we've been using in a project of ours.