Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Str::of for Laravel 6 compatibility #76

Merged
merged 3 commits into from
May 13, 2022
Merged

remove Str::of for Laravel 6 compatibility #76

merged 3 commits into from
May 13, 2022

Conversation

chrisGeonet
Copy link
Contributor

No description provided.

@freekmurze
Copy link
Member

Seems like this PR contains breaking changes.

@chrisGeonet
Copy link
Contributor Author

chrisGeonet commented May 13, 2022 •
edited

Updated code is ready for testing

@chrisGeonet
Copy link
Contributor Author

I can't get the tests to run locally so didn't spot that Laravel 6 doesn't have Str::replace.
Manually updated the code in a current project to test wildcards and it appears to be working now.

@freekmurze freekmurze merged commit 0d9e34a into spatie:main May 13, 2022
@freekmurze
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisGeonet @freekmurze