Use Laravel container on private Router - closes #77 #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #77
As the container parameter is nullable in
Illuminate\Routing\Router
's constructor, an empty container is assigned in its constructor when no container is provided.Since laravel/framework#44339 introduced
Illuminate/Routing/Contracts/CallableDispatcher
, a router needs this interface bound to dispatch closure bound routes such as the ones registered here:laravel-missing-page-redirector/src/MissingPageRouter.php
Lines 42 to 53 in ba2bc5f
This PR
Router
constructor in this package's Service Provider, so it has a container which knows how to build aCallableDispatcher
instance.