generated from spatie/package-skeleton-laravel
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add version check for lang_path helper
- Loading branch information
Voicecode B.V
committed
Feb 22, 2022
1 parent
1be0f3a
commit 9aa990a
Showing
2 changed files
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9aa990a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this change be applied also to the
loadJsonTranslationsFrom
function calls below?Can I go ahead with the PR? @freekmurze
Also wouldn't be better to check for
lang_path
existence rather than Laravel version?Thanks
9aa990a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, if you want, you can send a PR for that.
That might be a bit better too, feel free to address it in the same PR.