Specify commands that will not be available on http calls

[systemsolutionweb]

There are some commands that should not be able to be executed from the context of web application interfaces, like InstallCommand, NetworkCommand

This PR gives us the option to register commands that will exclusively be used from the console.

Also on laravel documentation there is an example https://laravel.com/docs/10.x/packages#commands (runningInConsole)

Example:

$package
    ->name('your-package-name')
    ->hasConfigFile()
    // console context command
    ->hasConsoleCommand(ConsoleExclusiveCommand::class)
    // console/web context command
    ->hasCommand(GlobalCommand::class)
    // InstallCommand must be console context command
    ->hasInstallCommand(function(InstallCommand $command) {
        $command
            ->publishMigrations();
    })

This was broken here: #23

[freekmurze]

Thanks!

I'd don't see any difference in handling compared to our current method: https://github.com/spatie/laravel-package-tools/pull/89/files#diff-019f7c923ae71364e0c7e058efe9cd6c43a4955d8c5b6461b2a69e3f04979bcfR101-R108

[systemsolutionweb]

@freekmurze hi, thanks for answer

I'd don't see any difference in handling compared to our current method

• if there is much difference. look at Execute command in context of the app #23

in that PR it was added that all the commands can be executed from the context of http calls,
with this PR we can decide if the commands should be accessible from http calls or are exclusively from the context of console calls, or divide them

Example:
Currently the InstallCommand command is registered so that it is accessible from http calls, which is unnecessary and should only be accessible from the console context

laravel-package-tools/src/Package.php

Lines 69 to 73 in d7ea4f7

	$installCommand = new InstallCommand($this);
	$callable($installCommand);
	$this->commands[] = $installCommand;

Here is the conditional

laravel-package-tools/src/PackageServiceProvider.php

Line 58 in d7ea4f7

if ($this->app->runningInConsole()) {

I will modify the PR for better readability

[freekmurze]

Is this flag being used somewhere? Seems like the dedicated hasConsoleCommand already covers this functionality. Could you remove the flag?

[freekmurze]

Seems like the tests are failing, could you have a look

[freekmurze]

Thanks!