Merge pull request #96 from vintagesucks/default-paper-format

fix default paper format in docs
spatie · Mar 4, 2024 · f0042df · f0042df
2 parents b263e83 + 35a8f31
commit f0042df
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/docs/basic-usage/formatting-pdfs.md b/docs/basic-usage/formatting-pdfs.md
@@ -88,7 +88,7 @@ Pdf::view('pdf.invoice', ['invoice' => $invoice])
 
 ## Paper format
 
-By default, all PDFs are created in A4 format. You can change this by calling the `format` method.
+By default, all PDFs are created in Letter format. You can change this by calling the `format` method.
 
 ```php
 use Spatie\LaravelPdf\Facades\Pdf;

diff --git a/tests/DefaultPdfTest.php b/tests/DefaultPdfTest.php
@@ -21,6 +21,12 @@
         ->toContainText('test');
 });
 
+it('defaults to the letter format', function () {
+    Pdf::view('test')->save($this->targetPath);
+
+    expect($this->targetPath)->toHaveDimensions(612, 792);
+});
+
 it('will not use properties of the previous pdf when not setting a default', function () {
     $firstPath = getTempPath('first.pdf');
     Pdf::html('test')

diff --git a/tests/PdfTest.php b/tests/PdfTest.php
@@ -147,7 +147,7 @@
     expect(getTempPath('first.pdf'))
         ->toHaveDimensions(792, 612);
 
-    // second pdf is landscape
+    // second pdf is portrait
     expect(getTempPath('second.pdf'))
         ->toHaveDimensions(612, 792);
 });