[V5] Cache loader improvements

[erikn69]

• Deleted old V4 fallbacks
• Early return used
• Avoid use same bucle twice on permisions (collect($this->permissions)->map() and later ->each())
• array_map instead of collect($this->permissions)->map()->all() and other collect() again with the first collect

[freekmurze]

To me, the old and new code is unreadable. Could you split this up in dedicated functions that are clearly named and explain what is happening?

[erikn69]

I have another commit that makes cache 50% smaller by serialization of Role model ids,
but I have not uploaded it because I know you like the changes in parts, so I waiting to see if this is ok

[freekmurze]

Will these cache improvements break if people have already cached things using the old way?

[erikn69]

@freekmurze no breaks, there is a if that forget cache if it is old versions, a temporal fix for that

// must be removed on next mayor version
 if (! isset($this->permissions['permissions'])) {
    $this->forgetCachedPermissions();
    $this->loadPermissions();

    return;
}

[Restingo]

Typo

[angeljqv]

@freekmurze will this PR be merged?

[freekmurze]

Thanks! 👍

[erikn69]

Thank you, i am getting better times and less ram usage