Add Cache Repository getter on PermissionRegistrar
#1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
reviewed
Dec 17, 2021
src/PermissionRegistrar.php
Outdated
| } | ||
|
|
||
| protected function getCacheStoreFromConfig(): \Illuminate\Contracts\Cache\Repository | ||
| public function getCacheRepository(): Repository |
There was a problem hiding this comment.
Renaming this function seems like unnecessarily risky. Why not just change protected to public so this won't break other people's code?
There was a problem hiding this comment.
@freekmurze done,
I added a specific getter for that, not breaking changes
angeljqv
changed the title
PermissionRegistrar
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make public Cache Repository getter, usefull when creating custom traits and we want to manipulate permission cache repository
Also acording https://spatie.be/guidelines/laravel-php#docblocks, phpdoc from
getCacheStoreremoved