for more connection database

[ihyme]

No description provided.

[erikn69]

Did you run tests?

Maybe it's a breaking change, because not everybody uses mysql as database(i don't), you could publish and customize migration as you wish

Also, if you want to contribute, at least put a fallback for everybody without 'connection'=>'custom_connection' on their config

-config('permission.connection');
+config('permission.connection') ?: config('database.default');

[erikn69]

Other less intrusive way is putting db name on config, example:

'table_names' => [
    'roles' => 'CUSTOM_DB_NAME.roles',
    'permissions' => 'CUSTOM_DB_NAME.permissions',
    'model_has_permissions' => 'CUSTOM_DB_NAME.model_has_permissions',
    'model_has_roles' => 'CUSTOM_DB_NAME.model_has_roles',
    'role_has_permissions' => 'CUSTOM_DB_NAME.role_has_permissions',
],

It works, test it,
also with env()

'table_names' => [
    'roles' => env('DB_DATABASE', 'CUSTOM_DB_NAME').'.roles',
    ///

laravel-permission/config/permission.php

Lines 39 to 55 in 8a69aad

	'roles' => 'roles',
	/*
	* When using the "HasPermissions" trait from this package, we need to know which
	* table should be used to retrieve your permissions. We have chosen a basic
	* default value but you may easily change it to any table you like.
	*/
	'permissions' => 'permissions',
	/*
	* When using the "HasPermissions" trait from this package, we need to know which
	* table should be used to retrieve your models permissions. We have chosen a
	* basic default value but you may easily change it to any table you like.
	*/
	'model_has_permissions' => 'model_has_permissions',

[ihyme]

thank you for enlightening me