Avoid calling the config helper in the role/perm model constructor

[adiafora]

I described the problem in #2097 with initializing the config.
I propose a solution.

Fixes #2097

[erikn69]

Closes #2097
What about Permission model ?

laravel-permission/src/Models/Permission.php

Line 25 in 8a69aad

$attributes['guard_name'] = $attributes['guard_name'] ?? config('auth.defaults.guard');

Could you test with facade \Config::get('auth.defaults.guard'), (Config.php)

[adiafora]

@erikn69 I think it needs fixing too. I'll do it

[adiafora]

I tried. The facade doesn't work either

[erikn69]

#2097 (comment)
Ok , i did test your solution and it don't do anything, look at this example

class Kernel extends ConsoleKernel
{
    public function __construct(
        Application $app,
        Dispatcher $events,
        private \Spatie\Permission\Models\Role $role
    ){
        parent::__construct($app,$events);
        var_dump($role->toArray(), (new \Illuminate\Config\Repository())->get('auth'));
    }
}

From that i am getting

php artisan cache:clear
array(1) {   
  ["guard_name"]=> NULL          # this is $role class
}
NULL                             # this is Config\Repository()
Application cache cleared!

It seems that accessing Config\Repository before container creation does not get any config values

---

I think that we can delete that line without problems, it seems to me that those lines are forgotten code from previous versions, it was replaced by Guard::getDefaultName on other methods

laravel-permission/src/Models/Role.php

Line 39 in 8a69aad

$attributes['guard_name'] = $attributes['guard_name'] ?? Guard::getDefaultName(static::class);

I did run test without those lines and everything works

PHPUnit 9.5.20

Runtime:       PHP 8.1.2
Configuration: /laravel-permission/phpunit.xml.dist

...............................................................  63 / 414 ( 15%)
............................................................... 126 / 414 ( 30%)
............................................................... 189 / 414 ( 45%)
............................................................... 252 / 414 ( 60%)
............................................................... 315 / 414 ( 76%)
............................................................... 378 / 414 ( 91%)
....................................                            414 / 414 (100%)

Time: 00:07.732, Memory: 48.00 MB

OK ( 414 tests, 928 assertions)

[adiafora]

@erikn69 I did. Could you take a look?

[erikn69]

I think that we can delete that line without problems,
I did run test without those lines and everything works

Read again

[adiafora]

I'm sorry. I misunderstood.
I did.

[adiafora]

ok, I did

[adiafora]

Did

[angeljqv]

@freekmurze ping

[JonPurvis]

Is it possible that this change is the cause of #2218?

I've switched my app from using v5.5.9 to v5.5.10 and the latter now has the above issue, switching back to v5.5.9 resolves it.

[erikn69]

@JonPurvis yes, it was

Try mi last PR