Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getKey, getKeyName instead of id #2116

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Use getKey, getKeyName instead of id #2116

merged 1 commit into from
Jun 29, 2022

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Jun 16, 2022

Same as others, more abstract on custom primary key names

laravel-permission/src/Traits/HasPermissions.php

Line 288 in 96466b0

return $this->permissions->contains($permission->getKeyName(), $permission->getKey());

@freekmurze freekmurze merged commit 7383335 into spatie:main Jun 29, 2022
@freekmurze
Copy link
Member

Thanks!

@erikn69 erikn69 deleted the patch-3 branch February 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikn69 @freekmurze