Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support static arrays on blade directives #2168

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Support static arrays on blade directives #2168

merged 1 commit into from
Oct 19, 2022

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Sep 5, 2022 •
edited

Closes #2165
Closes #1997 (comment)
Closes #626 (comment)
Closes #309

This PR adds support for arrays(also expressions) on blade directives, example

@hasanyrole(['admin', 'manager'])
        
@endhasanyrole

@hasallroles(['admin', 'manager'])
        
@endhasallroles

Without this PR only PIPE an VARIABLE's REF are supported

laravel-permission/tests/resources/views/guardHasAllRolesPipe.blade.php

Line 1 in dbc6c18

@hasallroles("super-admin|moderator", $guard)

laravel-permission/tests/resources/views/guardHasAllRoles.blade.php

Line 1 in dbc6c18

@hasallroles($roles, $guard)

@drbyte drbyte mentioned this pull request Oct 13, 2022
Merged
drbyte
drbyte reviewed Oct 18, 2022
View reviewed changes
tests/BladeTest.php Outdated Show resolved Hide resolved
@drbyte drbyte merged commit 882e501 into spatie:main Oct 19, 2022
@erikn69 erikn69 deleted the fix_2165 branch February 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbyte drbyte drbyte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikn69 @drbyte