Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after #2324 refactor #2326

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix tests after #2324 refactor #2326

merged 1 commit into from
Feb 13, 2023

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Feb 13, 2023

After #2324 this needs refactor

laravel-permission/database/migrations/create_permission_tables.php.stub

Lines 19 to 20 in 3115a43

$pivotRole = $columnNames['role_pivot_key'] ?? 'role_id';
$pivotPermission = $columnNames['permission_pivot_key'] ?? 'permission_id';

@drbyte
Copy link
Collaborator

drbyte commented Feb 13, 2023

Thanks!

@drbyte drbyte changed the title Fix tests Fix tests after #2324 refactor Feb 13, 2023
@drbyte drbyte merged commit 0c49776 into spatie:main Feb 13, 2023
@erikn69 erikn69 deleted the patch-17 branch February 17, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikn69 @drbyte