[V6] Register OctaneReloadPermissions listener for Laravel Octane

[erikn69]

i'm not 100% sure on this
i can't test octane

this was a test for octane users to try but no one gave me feedback that it works

On #2322 (comment) was said that the problem was the spatie/once package, and that spatie/laravel-permission works correctly on octane

I recommend not merging it until you do more testing that it's the correct approach.

[drbyte]

I recommend not merging it until you do more testing that it's the correct approach

Agreed. I more just wanted it here as an easy place to reference the specific proposed fix. And if it's deemed "right" and not problematic, it's a simple thing then to merge it.
Thanks!

[drbyte]

@sweebee Are you able to test this? In reference to your issue #2401

[sweebee]

@drbyte Yes, its working!

[davidjr82]

This solution will reload the permissions in every single tick of the octane server. Wouldn't this result in a drop of performance?

Also, we should make (I don't know how...) a test case where we can see it failing without this change, otherwise it wouldn't add anything.

[drbyte]

This solution will reload the permissions in every single tick of the octane server. Wouldn't this result in a drop of performance?

@sweebee Do you mind testing what benefits or drawbacks occur if not registering it with the Tick events?

Also, we should make (I don't know how...) a test case where we can see it failing without this change, otherwise it wouldn't add anything.

@sweebee Any thoughts on how best to automate such tests?

[drbyte]

@sweebee @davidjr82 does the change to listening on OperationTerminated work satisfactorily in your app?

[davidjr82]

For me the issue was in a different package (spatie/once) so this package worked without any change.

[parallels999]

this package worked without any change.
this result in a drop of performance

it would be better to make it optional, so, can be activated from permission.php for whoever needs it
Like

/*
 * When set to true, the Spatie\Permission\Listeners\OctaneReloadPermissions listener will be registered
 * on the Laravel\Octane\Events\OperationTerminated event, this will refresh permissions on every
 * TickTerminated, TaskTerminated and RequestTerminated
 */
'register_octane_permissions_refresh' => true,

[davidjr82]

this package worked without any change.
this result in a drop of performance

it would be better to make it optional, so, can be activated from permission.php for whoever needs it
Like

/*
 * When set to true, the Spatie\Permission\Listeners\OctaneReloadPermissions listener will be registered
 * on the Laravel\Octane\Events\OperationTerminated event, this will refresh permissions on every
 * TickTerminated, TaskTerminated and RequestTerminated
 */
'register_octane_permissions_refresh' => true,

I agree on this, although I wouldn't push a feature without a working test.

But if in this case we don't know how to do it, at least make it optimal sounds reasonable to me.

[erikn69]

it would be better to make it optional

that could also apply

[drbyte]

I'm in agreement with adding a config switch. Just undecided about the best name for it.
The variant I'm contemplating is register_octane_reset_listener

[drbyte]

adding tests

I agree: it would be preferable to get some tests set up for Octane. #HelpWanted

[drbyte]

@freekmurze do you have a preference on incorporating tests for this?