Test alternate cache drivers #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see your point. Ya the temporary file is one way. But that makes me contemplate just using the yml to drive it all?
If they all take too long in one batch, we could push the memcached and redis to separate test yml's. |
erikn69
force-pushed
the
patch-26
branch
4 times, most recently
from
1203ac5
to
13e579c
Compare
|
Looks great! Question: do we know for certain that the expected driver is being used in each variation? 👀 |
I guess it is. (https://github.com/drbyte/laravel-permission/actions/runs/4814920227/jobs/8573107658) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2413
It seems to work correctly, but I don't know if it is the most appropriate option