Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add laravel 11 to workflow run tests #2605

Merged
merged 5 commits into from Feb 28, 2024

Conversation

mraheelkhan
Copy link
Contributor

No description provided.

@drbyte
Copy link
Collaborator

drbyte commented Feb 8, 2024

The Passport integration for Laravel 11 is failing in the test suite.

Copy link

@gnovaro gnovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/run-tests.yml Show resolved Hide resolved
@danharrin danharrin mentioned this pull request Feb 26, 2024
10 tasks
@drbyte
Copy link
Collaborator

drbyte commented Feb 28, 2024

It appears that Laravel's new timestamp-override feature prevents Orchestra from working properly when using artisan to call passport:install (it doesn't cleanup the migration files, and just keeps adding them to the migrations folder).

So, the solution seems to be to manually run the install steps that Passport would do when calling passport:install.

@drbyte drbyte merged commit 05cce01 into spatie:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants