Fix can't save the same model twice

[erikn69]

• Closes Cannot save the user model twice in the same request #2638

This doesn't solve the problem completely Another approach seems to work

$user->save();
//$user = $user->fresh();
$user->save();

[drbyte]

Right. I'm wondering the same thing.

[drbyte]

Would this be safe instead?

-    $model->roles()->attach($roles, $teamPivot);
+    $currentRoles = $model->roles->map(fn ($role) => $role->getKey())->toArray();
+    $model->roles()->attach(array_diff($roles, $currentRoles), $teamPivot);

[erikn69]

set a flag

Seems, to work
I don't know if Laravel has a way to remove the callback after a single execution or if you can locate and remove the callback.

$class = \get_class($model);
$saved = false;

$class::saved(
    function ($object) use ($permissions, $model, $teamPivot, &$saved) {
        if ($saved || $model->getKey() != $object->getKey()) {
            return;
        }
        $model->permissions()->attach($permissions, $teamPivot);
        $model->unsetRelation('permissions');
        $saved = true;
    }
);