Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to store files in sub-folder #72

Merged
merged 6 commits into from
Jun 4, 2022
Merged

Conversation

jeremyallebe
Copy link

This pull request allow to store files via addFile() function into a sub folder of the archive.

@jeremyallebe jeremyallebe marked this pull request as ready for review May 25, 2022 13:38
Copy link
Member

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests that prove that this works and also update the readme?

src/PersonalDataSelection.php Outdated Show resolved Hide resolved
src/PersonalDataSelection.php Outdated Show resolved Hide resolved
src/PersonalDataSelection.php Outdated Show resolved Hide resolved
@jeremyallebe
Copy link
Author

I refactored some part of my code and add some tests.

@freekmurze
Copy link
Member

Could you also update the readme?

@jeremyallebe
Copy link
Author

Yes sure, i updated it

README.md Outdated Show resolved Hide resolved
@jeremyallebe
Copy link
Author

jeremyallebe commented Jun 3, 2022

Hey @freekmurze
can you merge the pull request? Or maybe some other changes to do?
Thanks

@freekmurze freekmurze merged commit 16f5088 into spatie:main Jun 4, 2022
@freekmurze
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants