Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignorable values #126

Closed
wants to merge 2 commits into from
Closed

Allow ignorable values #126

wants to merge 2 commits into from

Conversation

Propaganistas
Copy link
Contributor

@Propaganistas Propaganistas commented Oct 30, 2018 •
edited

Quick & dirty take on #104 .
Proof of concept.

Please adjust style & add tests yourself if this gets merged.

@freekmurze
Copy link
Member

Could you add tests to this PR?

@Propaganistas
Copy link
Contributor Author

Quick & dirty take on #104 .
Proof of concept.

Please adjust style & add tests yourself if this gets merged.

@freekmurze
Copy link
Member

Thank you for this, but currently closing because the PR doesn't contain tests. We'll take a look at the code when implementing the feature.

@freekmurze freekmurze closed this Nov 12, 2018
@Propaganistas Propaganistas deleted the ignorable-filters branch November 12, 2018 14:58
@dominikb dominikb mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoteo7 timoteo7 timoteo7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Propaganistas @freekmurze @timoteo7