Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check non existing relationships #454

Closed
wants to merge 1 commit into from
Closed

check non existing relationships #454

wants to merge 1 commit into from

Conversation

pkboom
Copy link

@pkboom pkboom commented Mar 21, 2020

This PR enables to check if relationships exist for includes. I will add a test and a exception if this PR is considered ok. Not sure checking for relationships at this level would be enough. Welcome any comments. Thanks. I've read source code of many packages you guys created and it's helped me a lot. I appreciate it.

Copy link
Member

@AlexVanderbist AlexVanderbist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Feel free to go ahead with adding the tests and exception :)

src/Concerns/AddsIncludesToQuery.php Show resolved Hide resolved
src/Concerns/AddsIncludesToQuery.php Show resolved Hide resolved
src/Concerns/AddsIncludesToQuery.php Show resolved Hide resolved
@pkboom
Copy link
Author

pkboom commented Apr 14, 2020

Opps. Files have been deleted. I will make a PR again.

@pkboom pkboom closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants