Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts string value for query param "fields" #872

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

ezra-obiwale
Copy link
Contributor

In addition to accepting GET param fields like

fields[table1]=col1,col2&fields[table2]=col1,col2

this PR makes it possible to accept values like

fields=table1.col1,table1.col2,table2.col1,table2.col2

And if table1 is the table for the target resource, then it can simply be like

fields=col1,col2,table2.col1,table2.col2

@BBrey
Copy link

BBrey commented Jul 12, 2023

We would really love this, because now we actually need to fill in the table name like table_link_to_table when using the fields

@AlexVanderbist
Copy link
Member

Nice PR, thanks!

@AlexVanderbist AlexVanderbist merged commit ec9f52d into spatie:main Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants