Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threshold for dispkace's alerts #39

Merged
merged 4 commits into from
Apr 24, 2017
Merged

Add threshold for dispkace's alerts #39

merged 4 commits into from
Apr 24, 2017

Conversation

ptondereau
Copy link
Contributor

@ptondereau ptondereau commented Apr 21, 2017

This PR just add an entry in config file to configure thresholds alert for diskpace.

@freekmurze
Copy link
Member

Could you remove all changes unrelated to adding the threshold to the config file?

@ptondereau
Copy link
Contributor Author

@freekmurze done

@freekmurze
Copy link
Member

For people using the old version of the config file this change will break their monitor. Could you make sure the previous values are used in the check if the new keys are not present in the config file?

@ptondereau
Copy link
Contributor Author

@freekmurze this should do the trick. Thanks for the suggest

@freekmurze freekmurze merged commit 89cbd6b into spatie:master Apr 24, 2017
@freekmurze
Copy link
Member

Thank you!

@ptondereau ptondereau deleted the feature/threshold-diskpace branch April 24, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants