Enforce priority value to be in the interval [0,1] (#212)

spatie · Nov 5, 2018 · fb10bca · fb10bca
1 parent 14a3787
commit fb10bca
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Tags/Url.php b/src/Tags/Url.php
@@ -87,7 +87,7 @@ public function setChangeFrequency(string $changeFrequency)
      */
     public function setPriority(float $priority)
     {
-        $this->priority = $priority;
+        $this->priority = max(0, min(1, $priority));
 
         return $this;
     }

diff --git a/tests/UrlTest.php b/tests/UrlTest.php
@@ -63,6 +63,18 @@ public function priority_can_be_set()
         $this->assertEquals(0.1, $this->url->priority);
     }
 
+    /** @test */
+    public function priority_is_clamped()
+    {
+        $this->url->setPriority(-0.1);
+
+        $this->assertEquals(0, $this->url->priority);
+
+        $this->url->setPriority(1.1);
+
+        $this->assertEquals(1, $this->url->priority);
+    }
+
     public function change_frequency_can_be_set()
     {
         $this->url->setChangeFrequency(Url::CHANGE_FREQUENCY_YEARLY);