New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to find models with tags of any type #157
Conversation
Thank you for this. 👍 Could you add tests to make sure that this works? I've remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough :))
I added the tests and they seem fine to me. But I could not run them, because:
Also, should I close this pull request and create a new one with tests or is there a way to add tests to this one? |
Travis reports that the Could you take a look at that?
Running the tests will run the migrations
That's normal, I'll update the readme
Never, you're safe here 😄
👍 |
It was one of the original tests that stopped working because I added
It was a very sophisticated problem related to using a Thanks for being welcoming. I guess this is ready. |
Thank you very much for your work on this! 👍 |
@mokhosh are you up for sending a PR to the docs for these two new scopes? |
Well, thank you for all your great packages! 👍
Sure, it's been fun. Also, there's a Farsi proverb that says "Do you know who did the job? The one who made it complete." 😄 |
This adds two new scopes:
and to be clean about it, I added one method to
HasTags
trait and another to theTag
model to convert given arguments to tags of any type and find tags of any type from strings:I also added
.idea
folder to gitignore :)