Allows models with any/all tags to be found disregarding type by passing false #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- e.g. $model->withAnyTags(['myTag'], false) - HasTags@192 allows false to bypass the type check
|
Thank you for this, but I prefer dedicated methods, like in #157, over a boolean. Hopefully that other PR can get merged soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were finding it a little restrictive not to be able to retrieve models by tag(s), disregarding type. This allows type to be ignored by passing false into the trait methods withAnyTags() and withAllTags(). NULL behaves as current.
This does have some crossover with #76, but is solving a different issue. This should only be breaking where false is being (inadvertently?) passed as second argument to methods above.
Tests added. All existing pass.