-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
withAnyTags and withAllTags doesn't ignore $type parameter when null #75
Comments
This seems to be a bug yes. I'd accept a PR that fixes this. Be sure to include tests. |
I prepared a PR for this issue with solution mentioned above changing But after examing Tag class closer I noticed that fix is not as easy because it might create another possibly unexpected behavior with If you use This passes
This fails on assertation that types are equal.
Possible solution is to check $type parameter
@freekmurze what do you think? |
Send in the PR and I’ll take a closer look. |
See #76 |
@freekmurze can you reopen the issue please? This still occurs. |
withAnyTags and withAllTags returns empty collection when you don't specify $type param, in case Tag has type set. Possibly same problem as in #28
Is this the intended behavior? It doesn't seem to be because I didn't notice any tests for it.
The problem is in
shouldnt it be?
because
scopeWithType
ignores $type when nullThe text was updated successfully, but these errors were encountered: