Make convertToTags() method $values arg support Tag instance #371
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as ` scopeWithAllTags() ` method, it's ` $tags ` arg can be `Tag` instance. But if we use Tag instance, `convertToTags` will go wrong, because ` collect ` function will convert `Tag` to array, and will create all attribute value as Tag. That is wrong.
|
Could you add a test for this? |
|
@freekmurze No, but I test in my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as
scopeWithAllTags()method, it's$tagsarg can beTaginstance. But if we use Tag instance,convertToTags()method will go wrong, becausecollectfunction will convertTagto array, and will query each attribute value forTag. That is wrong.For simplicity, I think we can handle it this way.