Fix the tests #52
Merged
Fix the tests #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone should fix whatever is wrong in here
|
Just wanted to say that, regardless of the outcome, I highly appreciate your help on fixing the tests. |
|
Seems like this fixes the tests but I have temporarily disabled I'm currently looking into what package (and what exact version) is causing this. After that is fixed we can have UPDATE: ⬆️ this was fixed |
|
Thank you very much for this 👍 |
|
Seems like there's still one strange thing going on. No tests are executed when using PHP 7.1 with the lower requirements. Example: https://travis-ci.org/spatie/laravel-tags/jobs/244072893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.