New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting a translation directly through the property #80

Merged
merged 7 commits into from Sep 21, 2017

Conversation

Projects
None yet
2 participants
@flofloflo
Contributor

flofloflo commented Sep 21, 2017

I reused some of bbrother's code from the PR #21 to realize the possibility to set translations with the default eloquent syntax ($model->key = 'Translation';) without using magic methods.

If a user sets a translation this way, the current app locale is used to save the translation (as it is already the case for getting translations).

@freekmurze freekmurze merged commit 56dae83 into spatie:master Sep 21, 2017

4 checks passed

Scrutinizer 1 updated code elements
Details
SensioLabsInsight Code quality OK.
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freekmurze

This comment has been minimized.

Show comment
Hide comment
@freekmurze

freekmurze Sep 21, 2017

Member

Very nice, thanks!

Member

freekmurze commented Sep 21, 2017

Very nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment