Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue path #28

Closed
wants to merge 2 commits into from

Conversation

@rgreer4
Copy link

commented Aug 22, 2019

This may not be the best way to do this -- but it worked well for me. Right now the "/tinker" path is easily changable the Larvel config, but hard-coded in the Vue file.

Changing that to "window.location.pathname" should let it work from any path configuration -- or in my case, when Laravel is running in subdirectory. (In that case, the Laravel path setting will not match the POST URL.)

rgreer4 added 2 commits Aug 22, 2019
@freekmurze

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

I'd rather have the configured endpoint in the config explicitly passed through from the controller to the Blade views / vue components.

Could you update this PR to work that way?

@rgreer4

This comment has been minimized.

Copy link
Author

commented Aug 22, 2019

Sure, but it might take me a bit. I'll close and submit a new PR once I've got that worked out. Thanks!

@rgreer4 rgreer4 closed this Aug 22, 2019

davejamesmiller added a commit to davejamesmiller/laravel-web-tinker that referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.