Support for Guzzle 7 #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrommone
commented
Jul 12, 2020
| @@ -79,7 +80,7 @@ public function handle() | |||
|
|
|||
| return; | |||
| } catch (Exception $exception) { | |||
| if ($exception instanceof RequestException) { | |||
| if ($exception instanceof TransferException || $exception instanceof RequestException) { | |||
There was a problem hiding this comment.
Class GuzzleHttp\Exception\ConnectException now extends GuzzleHttp\Exception\TransferException instead of GuzzleHttp\Exception\RequestException.
This is a part of the upgrade guide. I've added a new exception here but it sounds like it is not working. Never worked with standalone packages supporting a range of versions so idk what to do next.
There was a problem hiding this comment.
@freekmurze can you take a look here? 😇
|
Seems like the tests are failing for this PR. Could you take a look at that? |
|
The latest release now support Guzzle 7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've read all the upgrade guide from Guzzle 6 to 7 and sound like everything is ok.