Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that I miss about this package is the ability to get the UUID property of the job being dispatched, and decided to implement this during Hacktoberfest.
Why this is useful
In my projects, every critical communication that our servers establish with others have to be logged on Elasticsearch. It's important to be able to track things, and UUIDs are excellent for that. By default, when we call
WebhookCall::create()
it will use the default values from the configuration, except for one: the UUID, which is defined in that moment.To be able to persist and "associate" the job dispatched with the document on Elasticsearch, we are overriding the UUID property, just because we do not have access to the default value created by the package. It is a minor improvement, but one less overhead.