Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed peers get to package.json in "dependencies" section when using npm 5 #13

Closed
jehy opened this issue Jul 10, 2017 · 11 comments
Closed

Comments

@jehy
Copy link
Contributor

jehy commented Jul 10, 2017

Installed peers get to package.json in "dependencies" section when using npm 5. This is likely related to npm 5 adding to "dependencies" even without "save" flag.

This can ve avoided with setting flag npm config set save false cbut setting this for user environment is wrong.

Also seems that we can use --no-save flag, I am gonna test it.

UPD. Looks fine, added a PR.

@jehy
Copy link
Contributor Author

jehy commented Jul 11, 2017

It is possible that I spelled option wrong, if so - check marapper@07fc6a6

@sschuberth
Copy link

Isn't this very related to my issue #12?

sebastiandedeyne added a commit that referenced this issue Aug 16, 2017
@sebastiandedeyne
Copy link
Member

1.2.0-rc.1 should fix this. Could anyone give it a spin?

@alexindigo
Copy link

It's because of this line: https://github.com/spatie/npm-install-peers/blob/master/src/index.js#L33

There is no no-save option in npm, --no-save argument is translated into save: false option.

@MarkChrisLevy
Copy link

@sebastiandedeyne In 1.2.0-rc.1 this is not fixed. As @alexindigo noted, there should be "--no-save" argument, not "no-save".

@alexindigo
Copy link

@mmlleevvyy Checkout npmjs.org/install-peers it has that issue fixed and automates things a little bit further :)

@sebastiandedeyne
Copy link
Member

Released 1.2.0-rc.2 with a fix for the --no-save argument.

@alexindigo
Copy link

I think it works a little bit different from what your fix implies.
--no-save is parsed from cli args into options['save'] = false.

@sebastiandedeyne
Copy link
Member

Published another go

@alexindigo
Copy link

Looks good 👍

@sebastiandedeyne
Copy link
Member

Stable version 1.2.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants