Caching does not work

[francoism90]

I have tried multiple drivers, but it seems to fail at:

if ($this->config->shouldUseCache() && $this->config->cacheDriver->has($this->config->cacheId)) {

This is my ComponentScout:

<?php

use Illuminate\View\Component;
use Spatie\StructureDiscoverer\Cache\FileDiscoverCacheDriver;
use Spatie\StructureDiscoverer\Discover;
use Spatie\StructureDiscoverer\StructureScout;

class ComponentScout extends StructureScout
{
    public ?string $path = null;

    public ?string $prefix = null;

    protected function definition(): Discover
    {
        return Discover::in($this->path)
            ->withCache($this->identifier(), $this->cacheDriver())
            ->parallel()
            ->extending(Component::class)
            ->full();
    }

    public function identifier(): string
    {
        return $this->prefix ?? static::class;
    }

    public function cacheDriver(): FileDiscoverCacheDriver
    {
        return new FileDiscoverCacheDriver(
            directory: sys_get_temp_dir(),
            filename: $this->identifier(),
        );
    }

    public function prefix(string $prefix): static
    {
        $this->prefix = $prefix;

        return $this;
    }

    public function path(string $path): static
    {
        $this->path = $path;

        return $this;
    }
}

This is how I call the scout:

$components = ComponentScout::create()
            ->path('App')
            ->prefix('my-components')
            ->get();

It does find them, but it doesn't use caching at all. It also doesn't create the /tmp/my-components file.

[francoism90]

This seem to work:

$scout = ComponentScout::create()
            ->path($path)
            ->prefix($prefix);

        $structure = $scout->isCached()
            ? $scout->get()
            : $scout->cache();

So if I understand correctly, you need to first make the cache (this calls put), and later use get, to retrieve the cached result.

Should the isCached() not be part of the get() method on the Discover class?

Thanks.

[freekmurze]

We'll handle this further in #18