Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate snapshot file names with dataset #163

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Generate snapshot file names with dataset #163

merged 1 commit into from
Feb 13, 2023

Conversation

pierres
Copy link
Contributor

@pierres pierres commented Feb 12, 2023

Add the data set name to the snapshot file names to generate separate snapshot files when dataProviders are used.

This should fix #162 and probably #161

Add the data set name to the snapshot file names to generate separate snapshot files when dataProviders are used.

This should fix #162 and probably #161
@benfreke
Copy link

This definitely closed #162 , I tested this locally and got the expected changes.

@freekmurze freekmurze merged commit 1e2359a into spatie:main Feb 13, 2023
@freekmurze
Copy link
Member

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSnapShot no longer includes the name of the data provider
3 participants