Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false if success variable not defined #635

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Return false if success variable not defined #635

merged 1 commit into from
Feb 2, 2022

Conversation

cmgmyr
Copy link
Contributor

@cmgmyr cmgmyr commented Feb 2, 2022

On occasion, within our Laravel test suite, we'll get random errors with Ray when a request cannot be completed. All that shows is a failure because the $success variable is not defined.

ErrorException : Undefined variable $success
 /project/vendor/spatie/ray/src/Client.php:60
 /project/vendor/spatie/ray/src/Client.php:39
 /project/vendor/spatie/ray/src/Client.php:66
...

After implementing this change locally, the underlying failure was able to bubble up as expected.

@freekmurze freekmurze merged commit 28f6bd8 into spatie:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants