Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert version of spatie/macroable to ^1.0 #703

Merged
merged 1 commit into from
May 31, 2022
Merged

Revert version of spatie/macroable to ^1.0 #703

merged 1 commit into from
May 31, 2022

Conversation

SebKay
Copy link
Contributor

@SebKay SebKay commented May 31, 2022

This is because spatie/macroable ^2.0 is only compatible with PHP ^8.0, but spatie/ray is supposed to support PHP ^7.4|^8.0.

The issue is the following line in spatie/macroable: https://github.com/spatie/macroable/blob/main/src/Macroable.php#L14. It uses the pipe operator in the method signature, which PHP ^7.4 doesn't understand, hence the error.

Here's the error:

Fatal error: During class fetch: Uncaught ParseError: syntax error, unexpected '|', expecting variable (T_VARIABLE) in .../vendor/spatie/macroable/src/Macroable.php:14

Hopefully it's ok to revert this, but I understand if it's not viable!

Thanks for the time and effort you've put into the Ray plugin. I've found it tremendously helpful over the last year!

@freekmurze freekmurze merged commit 17654b9 into spatie:main May 31, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants