Adds namedGroup method into MatchResult #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cv21
force-pushed
the
feature/match-named-groups
branch
from
12fa7f2
to
6fce6e1
Compare
| * | ||
| * @param string $groupName | ||
| * | ||
| * @return mixed |
There was a problem hiding this comment.
Won't this always return a string?
|
Nice! Added a small comment, and could you get rid of the |
cv21
force-pushed
the
feature/match-named-groups
branch
2 times, most recently
from
fbded2a
to
6100007
Compare
cv21
force-pushed
the
feature/match-named-groups
branch
from
6100007
to
022d4a7
Compare
|
It seems to be ok now |
|
Awesome, thanks! Sidenote, if I tag a 2.0 someday, I'd probably consolidate the |
Closed
|
Yes, i understood. So, waiting for 2.0 :) Nice project, @sebastiandedeyne! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for named groups and fulfill corresponding issue