Update README.md #76
Merged
Update README.md #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the example from the readme
Ssh::create('user', 'host')->onOutput(fn($type, $line) => echo $line)->execute('whoami');
I am getting the following error
Parse error: syntax error, unexpected token "echo"
When using the following syntax it works
Ssh::create('user', 'host')->onOutput(function($type, $line) {echo $line;})->execute('whoami');
|
ThE current syntax is valid in PHP 7.4 and above |
|
It is valid syntax but it still complains https://3v4l.org/ai9XS#v7.4.33 |
|
Ah, it's because a short closure tries to return something and it can't do that with the So, you were right, the current syntax is invalid. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the example from the readme
Ssh::create('user', 'host')->onOutput(fn($type, $line) => echo $line)->execute('whoami');I am getting the following error
Parse error: syntax error, unexpected token "echo"When using the following syntax it works
Ssh::create('user', 'host')->onOutput(function($type, $line) {echo $line;})->execute('whoami');