Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to load from file a DER based certificate #177

Merged
merged 3 commits into from
Oct 28, 2022
Merged

add the ability to load from file a DER based certificate #177

merged 3 commits into from
Oct 28, 2022

Conversation

marco-introini
Copy link
Contributor

With this little improvement it's now possible to load a file in which the certificate used is in binary DER based format instead of classic PEM format.

src/helpers.php Outdated Show resolved Hide resolved
tests/SslCertificateFromFileTest.php Show resolved Hide resolved
@marco-introini
Copy link
Contributor Author

I moved the der2pem function inside the SslCertificate class as a public static function.
Previous test didn't work for connection error on site with different port. I found another one (casually) which works for now and modified them.
Hope this can help

Thank you so much

@freekmurze freekmurze merged commit 69a61d2 into spatie:main Oct 28, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants